Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: When patching the elements that use innerHTML or textContent should first unmountChildren #11159

Merged
merged 9 commits into from
Jul 17, 2024
Merged

fix: When patching the elements that use innerHTML or textContent should first unmountChildren #11159

merged 9 commits into from
Jul 17, 2024

Conversation

linzhe141
Copy link
Contributor

close #9135

@linzhe141 linzhe141 changed the title fix: When patching, elements that use innerHTML and textContent should first unmountChildren fix: When patching the elements that use innerHTML or textContent should first unmountChildren Jun 17, 2024
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90 kB (-36 B) 34.5 kB (-13 B) 31.1 kB (-42 B)
vue.global.prod.js 147 kB (-36 B) 54 kB (-15 B) 48 kB (-99 B)

Usages

Name Size Gzip Brotli
createApp 49.8 kB (-22 B) 19.5 kB (-8 B) 17.8 kB (-1 B)
createSSRApp 53.3 kB (-36 B) 21 kB (-6 B) 19.1 kB (-2 B)
defineCustomElement 52.1 kB (-22 B) 20.3 kB (-9 B) 18.5 kB (-9 B)
overall 63.3 kB (-22 B) 24.5 kB (-10 B) 22.3 kB (+2 B)

@yyx990803 yyx990803 merged commit 3e9e32e into vuejs:main Jul 17, 2024
11 checks passed
@linzhe141 linzhe141 deleted the fix-innerHTML branch July 17, 2024 08:48
@gguoyu gguoyu mentioned this pull request Aug 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔩 p2-edge-case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

innerHTML set from render function goes missing when patching?
3 participants
@linzhe141 @yyx990803 @haoqunjiang